Basic completion structure + dot completions #811

gabritto · 2025-04-21T18:43:27Z

This PR introduces the basic completion workflow (getCompletionData, completionInfoFromData, etc), and dot completions. Global completions remain unimplemented, i.e. we're not collecting symbols for them.

I haven't tested the implementation yet beyond a very basic test, and some helpers are unimplemented, but I'd like to get the code in because there's helper code that may be shared by other services that are also being ported now.

gabritto · 2025-04-21T18:56:34Z

internal/checker/utilities.go

@@ -245,37 +239,6 @@ func isInTypeQuery(node *ast.Node) bool {
 	}) != nil
 }

-func isTypeOnlyImportDeclaration(node *ast.Node) bool {


Moved to ast/utilities

gabritto · 2025-04-21T18:56:46Z

internal/checker/utilities.go

@@ -483,26 +446,8 @@ func isRightSideOfQualifiedNameOrPropertyAccess(node *ast.Node) bool {
 	return false
 }

-func getSourceFileOfModule(module *ast.Symbol) *ast.SourceFile {


Moved to ast/utilities

gabritto · 2025-04-21T18:56:58Z

internal/checker/utilities.go

@@ -957,20 +902,6 @@ func compareTypeMappers(m1, m2 *TypeMapper) int {
 	return 0
 }

-func getClassLikeDeclarationOfSymbol(symbol *ast.Symbol) *ast.Node {


Moved to ast/utilities

gabritto · 2025-04-21T18:58:27Z

internal/checker/utilities.go

@@ -1800,10 +1722,11 @@ func canIncludeBindAndCheckDiagnostics(sourceFile *ast.SourceFile, options *core
 	return isPlainJS || isCheckJS || sourceFile.ScriptKind == core.ScriptKindDeferred
 }

-func isCheckJSEnabledForFile(sourceFile *ast.SourceFile, compilerOptions *core.CompilerOptions) bool {


Moved to ast/utilities.

gabritto · 2025-04-21T19:00:39Z

internal/checker/checker.go

-// A reserved member name consists of the byte 0xFE (which is an invalid UTF-8 encoding) followed by one or more
-// characters where the first character is not '@' or '#'. The '@' character indicates that the name is denoted by
-// a well known ES Symbol instance and the '#' character indicates that the name is a PrivateIdentifier.
-func isReservedMemberName(name string) bool {


Moved to checker/utilities.

gabritto · 2025-04-21T19:00:56Z

internal/checker/utilities.go

 		}
 		return isRequireCall(initializer, true /*requireStringLiteralLikeArgument*/)
 	}
 	return false
 }

-func getLeftmostAccessExpression(expr *ast.Node) *ast.Node {


Moved to ast/utilities.

gabritto · 2025-04-21T19:32:45Z

internal/parser/parser.go

@@ -6342,14 +6342,6 @@ func (p *Parser) skipRangeTrivia(textRange core.TextRange) core.TextRange {
 	return core.NewTextRange(scanner.SkipTrivia(p.sourceText, textRange.Pos()), textRange.End())
 }

-func isClassMemberModifier(token ast.Kind) bool {


Moved to AST/utilities.

gabritto · 2025-04-21T19:32:59Z

internal/parser/utilities.go

@@ -24,15 +24,6 @@ func ensureScriptKind(fileName string, scriptKind core.ScriptKind) core.ScriptKi
 	return scriptKind
 }

-func getLanguageVariant(scriptKind core.ScriptKind) core.LanguageVariant {


Moved to AST/utilities.

gabritto · 2025-04-21T19:33:45Z

internal/project/service_test.go

@@ -222,62 +217,3 @@ func TestService(t *testing.T) {
 		})
 	})
 }
-


Moved this to testutil/projecttestutil.

gabritto · 2025-04-21T21:00:19Z

internal/checker/services.go

@@ -0,0 +1,427 @@
+package checker
+


This file has a bunch of checker functions that are meant to be used by services.
There are existing functions in checker.go that could probably move here later, e.g. GetSymbolAtLocation.

jakebailey

Just skimmed it for now, have not tested it out either.

jakebailey · 2025-04-21T22:03:12Z

internal/core/core.go

@@ -539,3 +539,21 @@ func levenshteinWithMax(s1 []rune, s2 []rune, maxValue float64) float64 {
 func Identity[T any](t T) T {
 	return t
 }
+
+func CheckEachDefined[S any](s []*S, msg string) []*S {


Are these functions used? The codecov extension shows them as uncovered.

Not yet. They're used in a function in completions.go that is not currently exercised by the tests, because I haven't added enough tests yet.

jakebailey · 2025-04-21T22:04:46Z

internal/ls/types.go

+	JsxAttributeCompletionStyleNone   JsxAttributeCompletionStyle = "none"
+)
+
+type UserPreferences struct {


Long term it'll be interesting to see if we do this the same way; LSP has a different idea of how preferences are communicated than what tsserver did. But for internal stuff, probably okay.

jakebailey · 2025-04-21T22:04:53Z

internal/ls/types.go

+type UserPreferences struct {
+	// Enables auto-import-style completions on partially-typed import statements. E.g., allows
+	// `import write|` to be completed to `import { writeFile } from "fs"`.
+	IncludeCompletionsForImportStatements *bool


Should these just be Tristate?

They could be. To answer this and your other comment above, I haven't looked at how to handle those custom options yet via LSP. I left things as *bool because that's closer to what we get from the LSP generated types.

internal/ls/utilities.go

jakebailey · 2025-04-21T22:05:53Z

internal/ls/utilities.go

+}
+
+// Returns a map of all names in the file to their positions.
+// !!! cache this


If you eventually need to do this, you'll probably just want to shove this onto the SourceFile like lineMap.

internal/ls/utilities.go

internal/ls/completions.go

jakebailey · 2025-04-21T22:11:43Z

internal/ls/completions.go

+	useSemicolons bool,
+	compilerOptions *core.CompilerOptions,
+	preferences *UserPreferences,
+	clientOptions *lsproto.CompletionClientCapabilities,


Man, we have so many params in the old codebase

internal/ls/completions.go

internal/ls/utilities.go

internal/lsp/server.go

DanielRosenwasser · 2025-04-22T18:11:22Z

I tried running it, and I'm not getting completions. However, when I requested completion at /*$*/ in the following example:

let/*$*/

I got the following:

[Error - 11:07:19 AM] Request textDocument/completion failed.
  Message: panic obtaining completions: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
	.../sdk/gotip/src/runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleCompletion.func1()
	D:/typescript-go/internal/lsp/server.go:398 +0x48
panic({0x7ff6973ac880?, 0x7ff697a5d5a0?})
	.../sdk/gotip/src/runtime/panic.go:783 +0x120
github.com/microsoft/typescript-go/internal/ast.IsStringLiteralLike(...)
	D:/typescript-go/internal/ast/utilities.go:322
github.com/microsoft/typescript-go/internal/ls.getCompletionData(0x400778ddc0, 0x4002f21348, 0x1, 0x40000f0318)
	D:/typescript-go/internal/ls/completions.go:734 +0x77c
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).getCompletionsAtPosition(0x40001b8390, 0x400778ddc0, 0x4002f21348, 0x1, 0x400ba36670, 0x40000f0318, 0x40001a2c00)
	D:/typescript-go/internal/ls/completions.go:270 +0x158
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideCompletion(0x40001b8390, {0x400000f640?, 0x400000f640?}, 0x1, 0x400ba36670, 0x40001a2c00, 0x40000f0318)
	D:/typescript-go/internal/ls/completions.go:32 +0x5c
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleCompletion(0x400007e210, 0x400ba7e1b0)
	D:/typescript-go/internal/lsp/server.go:403 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleMessage(0x400007e210, 0x400ba7e1b0)
	D:/typescript-go/internal/lsp/server.go:199 +0x114
github.com/microsoft/typescript-go/internal/lsp.(*Server).Run(0x400007e210)
	D:/typescript-go/internal/lsp/server.go:121 +0xb4
main.runLSP({0x40000680a0, 0x1, 0x2})
	D:/typescript-go/cmd/tsgo/lsp.go:52 +0x2f4
main.runMain()
	D:/typescript-go/cmd/tsgo/main.go:135 +0x100
main.main()
	D:/typescript-go/cmd/tsgo/main.go:123 +0x1c

gabritto · 2025-04-22T18:18:41Z

I tried running it, and I'm not getting completions. However, when I requested completion at /*$*/ in the following example:

let/*$*/

I got the following:

[Error - 11:07:19 AM] Request textDocument/completion failed.
  Message: panic obtaining completions: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
	.../sdk/gotip/src/runtime/debug/stack.go:26 +0x64
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleCompletion.func1()
	D:/typescript-go/internal/lsp/server.go:398 +0x48
panic({0x7ff6973ac880?, 0x7ff697a5d5a0?})
	.../sdk/gotip/src/runtime/panic.go:783 +0x120
github.com/microsoft/typescript-go/internal/ast.IsStringLiteralLike(...)
	D:/typescript-go/internal/ast/utilities.go:322
github.com/microsoft/typescript-go/internal/ls.getCompletionData(0x400778ddc0, 0x4002f21348, 0x1, 0x40000f0318)
	D:/typescript-go/internal/ls/completions.go:734 +0x77c
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).getCompletionsAtPosition(0x40001b8390, 0x400778ddc0, 0x4002f21348, 0x1, 0x400ba36670, 0x40000f0318, 0x40001a2c00)
	D:/typescript-go/internal/ls/completions.go:270 +0x158
github.com/microsoft/typescript-go/internal/ls.(*LanguageService).ProvideCompletion(0x40001b8390, {0x400000f640?, 0x400000f640?}, 0x1, 0x400ba36670, 0x40001a2c00, 0x40000f0318)
	D:/typescript-go/internal/ls/completions.go:32 +0x5c
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleCompletion(0x400007e210, 0x400ba7e1b0)
	D:/typescript-go/internal/lsp/server.go:403 +0xf4
github.com/microsoft/typescript-go/internal/lsp.(*Server).handleMessage(0x400007e210, 0x400ba7e1b0)
	D:/typescript-go/internal/lsp/server.go:199 +0x114
github.com/microsoft/typescript-go/internal/lsp.(*Server).Run(0x400007e210)
	D:/typescript-go/internal/lsp/server.go:121 +0xb4
main.runLSP({0x40000680a0, 0x1, 0x2})
	D:/typescript-go/cmd/tsgo/lsp.go:52 +0x2f4
main.runMain()
	D:/typescript-go/cmd/tsgo/main.go:135 +0x100
main.main()
	D:/typescript-go/cmd/tsgo/main.go:123 +0x1c

That's expected. I updated the description just now to make it more clear, but 1. only dot completions have a chance of working 2. many things are yet unimplemented and likely to error.

internal/lsp/server.go

Co-authored-by: Jake Bailey <[email protected]>

jakebailey

Tried it out and it doesn't crash, works in some cases too. LGTM 😄

gabritto added 17 commits March 25, 2025 09:54

start completions and getSymbolsInScope

8dbdd93

Merge branch 'main' into gabritto/completion

8ab310e

some of getcompletiondata

4e2514b

finish initial port of getTypeScriptMemberSymbols

8db06be

Merge branch 'main' into gabritto/completion

5becbaa

update submodule

0c29714

more completions

601c4ea

more completions: finish create completion entry

9d8edd1

Merge branch 'main' into gabritto/completion

1e26fa8

more completions

75a781c

format

bb92255

sketch of unit test

d515d6c

move service test setup to its own pacakge for reuse

71fce1a

WIP: findPrecedingToken

9d729a2

find preceding token

df5086e

completion basic member test passing

b4cc421

Merge branch 'main' into gabritto/completion

cb966b8

gabritto commented Apr 21, 2025

View reviewed changes

gabritto added 2 commits April 21, 2025 12:39

refactoring and fixes after merge

1aa96a4

re-add baselines

62b46e1

gabritto commented Apr 21, 2025

View reviewed changes

fix lint

29ec6ac

gabritto marked this pull request as ready for review April 21, 2025 21:21

skip completion server test if no embeded

c9ce06e

gabritto requested review from jakebailey, iisaduan and navya9singh April 21, 2025 21:31

jakebailey reviewed Apr 21, 2025

View reviewed changes

gabritto added 2 commits April 21, 2025 15:53

address CR

1514cfe

more refactoring

4b2821f

jakebailey reviewed Apr 21, 2025

View reviewed changes

internal/ls/completions.go Outdated Show resolved Hide resolved

jakebailey reviewed Apr 21, 2025

View reviewed changes

internal/ls/utilities.go Outdated Show resolved Hide resolved

gabritto added 3 commits April 22, 2025 08:37

more fixes

34f5b83

Merge branch 'main' into gabritto/completion

37ceade

add panic recovery, and send completion provider in lsp initialize

3b005d1

gabritto commented Apr 22, 2025

View reviewed changes

internal/lsp/server.go Outdated Show resolved Hide resolved

gabritto and others added 5 commits April 22, 2025 11:20

Merge branch 'main' into gabritto/completion

1745cd3

fix infinite loop

fa9885a

fix map

967fb76

print panic

3cc279c

Merge branch 'main' into gabritto/completion

079557e

gabrielluizsf approved these changes Apr 23, 2025

View reviewed changes

Merge branch 'main' into gabritto/completion

1a603f1

jakebailey requested changes Apr 23, 2025

View reviewed changes

internal/lsp/server.go Outdated Show resolved Hide resolved

Update internal/lsp/server.go

0e929aa

Co-authored-by: Jake Bailey <[email protected]>

jakebailey approved these changes Apr 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic completion structure + dot completions #811

Basic completion structure + dot completions #811

gabritto commented Apr 21, 2025 •

edited

Loading

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

gabritto Apr 21, 2025

jakebailey left a comment

jakebailey Apr 21, 2025

gabritto Apr 21, 2025 •

edited

Loading

jakebailey Apr 21, 2025

jakebailey Apr 21, 2025

gabritto Apr 21, 2025

jakebailey Apr 21, 2025

jakebailey Apr 21, 2025

DanielRosenwasser commented Apr 22, 2025 •

edited

Loading

gabritto commented Apr 22, 2025

jakebailey left a comment

@@ @@ -222,62 +217,3 @@ func TestService(t *testing.T) { @@
               		})
               	})
               }

Basic completion structure + dot completions #811

Are you sure you want to change the base?

Basic completion structure + dot completions #811

Conversation

gabritto commented Apr 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakebailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabritto Apr 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DanielRosenwasser commented Apr 22, 2025 • edited Loading

gabritto commented Apr 22, 2025

jakebailey left a comment

Choose a reason for hiding this comment

gabritto commented Apr 21, 2025 •

edited

Loading

gabritto Apr 21, 2025 •

edited

Loading

DanielRosenwasser commented Apr 22, 2025 •

edited

Loading